chore: migrate to npm
#529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheKohan
commented
Oct 28, 2024
| @@ -56,7 +56,7 @@ jobs: | |||
| example/ios/Pods | |||
| ~/Library/Caches/CocoaPods | |||
| ~/.cocoapods | |||
| key: build-ios-pods-${{ matrix.react-native-architecture }}-${{ hashFiles('example/node_modules/react-native/package.json') }} | |||
There was a problem hiding this comment.
react-native is now hoisted to the root
TheKohan
commented
Oct 28, 2024
| @@ -11,9 +11,9 @@ react { | |||
| // The root of your project, i.e. where "package.json" lives. Default is '../..' | |||
| // root = file("../../") | |||
| // The folder where the react-native NPM package is. Default is ../../node_modules/react-native | |||
| // reactNativeDir = file("../../node_modules/react-native") | |||
| reactNativeDir = file("../../../node_modules/react-native") | |||
There was a problem hiding this comment.
Honestly don't know if that could be inferred somehow it was commented out by default, but RN was resolved in /example/node_modules with yarn.
TheKohan
commented
Oct 28, 2024
|
|
||
| // We need to make sure that only one version is loaded for peerDependencies | ||
| // So we block them at the root, and alias them to the versions in example's node_modules | ||
| resolver: { |
There was a problem hiding this comment.
This was no longer necessary i suppose, since we didn't need to substitute react-native from example/node_modules
|
Closing this PR in favor of #539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes package manager from
yarntonpmto align with the rest of theExpensifyrepos.Details
run scriptscidocsnode_modulesresolution across the project, becausenpmcannot be blocked fromhoistingpackages (RFC)Related Issues
Manual Tests
Linked PRs